feat: Add ability to squash builds #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmpinder
added
the
type: feature
|
Can some code get reused from building cached image, instead of having to update CLI version twice & having 2 same codes for determining recipe? |
Good idea. I'll work on that |
xynydev
reviewed
Apr 27, 2024
fiftydinar
approved these changes
Apr 29, 2024
xynydev
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to support an older version of
buildahandpodmanproved too difficult. Instead we'll just run the build inside a container. From my own testing with the squash builds, when you runbuildah/podmaninside a container, the builds can be incredibly slow with all the multi-stages and mounts on theRUNinstructions. However, activating squash (--layers=false) the build runs just as fast as normal. Activating the squash feature will by default not make use of any cache abilities.